[13] RFR 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors

Xuelei Fan xuelei.fan at oracle.com
Tue Jul 9 15:05:57 UTC 2019


I looked at the code a while back.  It's good to me.

Xuelei

On 7/9/2019 7:35 AM, Weijun Wang wrote:
> Ping again.
> 
>> On Jul 2, 2019, at 10:51 AM, Weijun Wang <weijun.wang at oracle.com> wrote:
>>
>> "[13]" added to the subject.
>>
>>> On Jul 2, 2019, at 10:22 AM, Weijun Wang <weijun.wang at oracle.com> wrote:
>>>
>>> Please take a review at
>>>
>>>   http://cr.openjdk.java.net/~weijun/8225687/webrev.00/
>>>
>>> Most changes are around const usage in gssapi.h. Note that this is internal so the change could only prevent any coding error and will not be visible outside JDK.
>>>
>>> Other changes are inside gss_import_name(), gss_compare_name(). I also changed some names like get_oid_set_desc -> show_oid_set.
>>>
>>> Thanks,
>>> Max
> 
>>
> 


More information about the security-dev mailing list