[13] RFR 8227059: sun/security/tools/keytool/DefaultSignatureAlgorithm.java timed out

Weijun Wang weijun.wang at oracle.com
Tue Jul 9 15:21:08 UTC 2019



> On Jul 9, 2019, at 11:15 PM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
> It's interesting to use fake key generator.  The update looks fine to me.
> 
> I think, there are keytool test cases to use the real key generator for the coverage?

All other tests use real generators. The fake one is used here simply because keysize is too big.

Thanks,
Max

> 
> Xuelei
> 
> On 7/9/2019 7:35 AM, Weijun Wang wrote:
>> Ping again.
>>> On Jul 3, 2019, at 10:20 AM, Weijun Wang <weijun.wang at oracle.com> wrote:
>>> 
>>> Updated at https://cr.openjdk.java.net/~weijun/8227059/webrev.01. EC added.
>>> 
>>> --Max
>>> 
>>>> On Jul 2, 2019, at 11:04 PM, Weijun Wang <weijun.wang at oracle.com> wrote:
>>>> 
>>>> Please take a review at
>>>> 
>>>>  http://cr.openjdk.java.net/~weijun/8227059/webrev.00/
>>>> 
>>>> A fake DSA key pair generator with hardcoded keys. I haven't modified EC since it's quite fast.
>>>> 
>>>> Thanks,
>>>> Max
>>>> 
>>> 



More information about the security-dev mailing list