RFR[14] Re-enable Stateless Resumption On by default for merge to mainline

Anthony Scarpino anthony.scarpino at oracle.com
Fri Jul 19 16:59:01 UTC 2019


Boolean.parseBoolean will only return true on "true", any other entries 
will return false.   Since in this case true is the default, I would 
rather any other entry than "false" to revert to the default.  Therefore 
going back to the old way is better.

Tony

On 7/19/19 1:22 AM, Jaikiran Pai wrote:
> Actually, looking at this current code in JDK 14 (default branch), it 
> uses the "compareToIgnoreCase" version. So I guess, you did this change 
> to match with what's already there. So please ignore my previous comment.
> 
> -Jaikiran
> 
> On 19/07/19 12:18 PM, Jaikiran Pai wrote:
>>
>> Hello Tony,
>>
>> I'm not a reviewer, but just checking - is this following change 
>> intentional:
>>
>> -            statelessSession = Boolean.parseBoolean(st);
>> +            if (st.compareToIgnoreCase("false") == 0) {
>> +                statelessSession = false;
>> +            }
>>
>> The Boolean.parseBoolean, that's in JDK 13, should work here too.
>>
>> -Jaikiran
>> On 18/07/19 11:19 PM, Anthony Scarpino wrote:
>>> This is a changeset for preventing Stateless Resumption from being 
>>> turned off when JDK-8227551 is merged from 13 into the mainline repo. 
>>> This is the way the gatekeepers asked me to do it as oppose to 
>>> withholding 8227551 from the mainline merge.
>>>
>>> http://cr.openjdk.java.net/~ascarpino/8228396/webrev/
>>>
>>> Thanks
>>>
>>> Tony



More information about the security-dev mailing list