[13] RFR 8228341: SignTwice.java fails intermittently on Windows

Sean Mullan sean.mullan at oracle.com
Tue Jul 23 11:34:18 UTC 2019


Looks fine to me.

--Sean

On 7/23/19 2:28 AM, Weijun Wang wrote:
> Please review the patch below. This test signs the same jar multiple 
> times. It's mainly about making sure the manifest and signature file can 
> be updated correctly. There is no need to try different key algorithms. 
> We can also use a faster digest algorithm.
> 
> Thanks,
> Max
> 
> *diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt*
> *--- a/test/jdk/ProblemList.txt*
> *+++ b/test/jdk/ProblemList.txt*
> @@ -661,7 +661,6 @@
>   sun/security/tools/keytool/KeyToolTest.java                     
> 8224644 solaris-all
>   sun/security/tools/keytool/WeakAlg.java                         
> 8224644 solaris-all
> 
> 
> -sun/security/tools/jarsigner/compatibility/SignTwice.java       8228341 
> windows-all
>   sun/security/tools/jarsigner/warnings/BadKeyUsageTest.java      
> 8026393 generic-all
> 
> 
>   javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java       
> 8212096 generic-all
> *diff --git 
> a/test/jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java 
> b/test/jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java*
> *--- a/test/jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java*
> *+++ b/test/jdk/sun/security/tools/jarsigner/compatibility/SignTwice.java*
> @@ -36,7 +36,7 @@
>    * @test
>    * @library /test/lib ../warnings
>    * @compile Compatibility.java
> - * @run main/othervm
> + * @run main/othervm/timeout=600
>    *  -Djava.security.properties=./java.security
>    *  -Duser.language=en
>    *  -Duser.country=US
> @@ -46,8 +46,8 @@
>    *  -DtestComprehensiveJarContents=true
>    *  -DtestJarUpdate=true
>    *  -Dstrict=true
> - *  -DkeyAlgs=EC;#RSA;#DSA;
> - *  -DdigestAlgs=SHA-512
> + *  -DkeyAlgs=EC;0
> + *  -DdigestAlgs=SHA-256
>    *  SignTwice
>    */
>   public class SignTwice {
> 


More information about the security-dev mailing list