[13] RFR 8228456: Enhance tests after JDK-8217375

Sean Mullan sean.mullan at oracle.com
Wed Jul 24 15:30:35 UTC 2019


On 7/21/19 10:02 PM, Weijun Wang wrote:
> Please take a review at
> 
>     http://cr.openjdk.java.net/~weijun/8228456/webrev.00/
> 
> The change is contributed by Philipp Kunz. Since we are now in RDP 2 and we are not allowed to fix non-test P3 (and lower) bugs. I've removed all src/ changes in Philipp's patch (If I read correctly, is mostly on renaming methods, and brings no behavior change) and made necessary change in test codes to use original method names.

It is a pretty large set of changes though.

If they are not needed to fix any issues in 13, I would recommend 
pushing to the jdk mainline. We can always decide to backport to 13 or 
13u later once we get more assurance they are stable.

> I haven't read the changes yet. I only made sure they pass on my own system. Oracle's test farm is in maintenance during the weekend.

Since you are not the contributor, I think it is ok for you to be the 
main Reviewer.

--Sean


More information about the security-dev mailing list