RFR 8215032: Support Kerberos cross-realm referrals (RFC 6806)

[Martin Balao]

Hi Max,

Thanks for your feedback.

On 6/4/19 12:28 AM, Weijun Wang wrote:
> - java.security typos:
> 
>    492,497: ovewritten
>    496: infite
> 

Fixed.

> - CredentialsUtils.java:
> 
>    36: unused import
> 

Fixed.

> - KDCRep.java:
> 
>    no need to move the position
> 

Fixed.

> - ReferralsCache.java:
> 
>    Red Hat has different copyright lines. For example, in java.base. Maybe any one is OK. IANAL. Same with ReferralsTest.java.
> 
> share/classes/sun/security/ssl/ExtendedMasterSecretExtension.java:2: * Copyright (c) 2017, Red Hat, Inc. and/or its affiliates.
> share/classes/jdk/internal/misc/UnsafeConstants.java:2: * Copyright (c) 2019, Red Hat Inc. All rights reserved.
> share/classes/com/sun/crypto/provider/GHASH.java:3: * Copyright (c) 2015 Red Hat, Inc.
> 

Yes, that's right but the one in ReferralsCache.java and
ReferralsTest.java is the right one.

> BTW, is it worth adding some comments here?
> 

Yes. Comments added to the class and all the methods.

> - TicketFlags.java:
> 
>    55: enc-pa-rep (15)
>    Remove the whitespace before "(15)" to be consistent with others.
> 

Fixed.

> Everything else looks fine. You are free to push the change now.

Here it's Webrev.04:

 * http://cr.openjdk.java.net/~mbalao/webrevs/8215032/8215032.webrev.04/

Testing:
 * jdk/sun/security/krb5 regression testing passed.
 * Will run jdk-submit now.

If there are no further comments and jdk-submit tests succeed, I'll push
tomorrow (2019-06-06) at around 11 am EST.

Kind regards,
Martin.-