RFR (S) 8225695: 32-bit build failures after JDK-8080462 (Update SunPKCS11 provider with PKCS11 v2.40 support)

[Aleksey Shipilev]

On 6/13/19 12:39 PM, Alan Bateman wrote:
> On 13/06/2019 11:28, Aleksey Shipilev wrote:
>> Recent push broke at least x86_32:
>>    https://bugs.openjdk.java.net/browse/JDK-8225695
>>
>> Fix:
>>    http://cr.openjdk.java.net/~shade/8225695/webrev.01/
>>
>> Pretty sure format specifiers are still incorrect for 32-bit, but default build does not touch the
>> TRACE statements. Feel free to amend the patch and/or reassign this to somebody from security team.
>>
>> Testing: Linux {x86_32, x86_64} jdk_security [still hits JDK-8225678]
>>
> Would the jlong_to_ptr and ptr_to_jlong macros in jlong_md.h be useful here? We use these in other
> areas where where is a long field holding a reference to native resources.

Maybe? That header is from another library/module, though: libjava, and we are at libj2pkcs11. I am
a bit worried about introducing this dependency. It is probably fine to #include <jlong_md.h>?

-Aleksey



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20190613/f5170255/signature.asc>