RFR 8225180: SignedObject with invalid Key not throwing the InvalidKeyException in Windows

Sean Mullan sean.mullan at oracle.com
Thu Jun 13 12:28:55 UTC 2019


Yes, looks good.

--Sean

On 6/12/19 10:32 PM, Weijun Wang wrote:
> Like this?
> 
>     http://cr.openjdk.java.net/~weijun/8225180/webrev.01/
> 
> Thanks,
> Max
> 
>> On Jun 12, 2019, at 5:00 AM, Sean Mullan <sean.mullan at oracle.com> wrote:
>>
>> On 6/11/19 12:00 AM, Weijun Wang wrote:
>>> Oops, forgot to add the bug title in the subject.
>>>> On Jun 11, 2019, at 11:56 AM, Weijun Wang <weijun.wang at oracle.com> wrote:
>>>>
>>>> Please take a review at
>>>>
>>>>    https://cr.openjdk.java.net/~weijun/8225180/webrev.00
>>>>
>>>> I added some extra info into the exception message not realizing it will be a bug. Revert back to previous code.
>>
>> It is fine I guess, but you could workaround the null key if the additional info in the exception message is useful.
>>
>> --Sean
> 



More information about the security-dev mailing list