[8u] [RFR] 8175120: Remove old tests on kdc timeout policy

Aleksey Shipilev shade at redhat.com
Wed Mar 13 16:28:38 UTC 2019


On 3/12/19 11:54 AM, Severin Gehwolf wrote:
> On Mon, 2019-03-11 at 07:50 +0000, Andrew John Hughes wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8175120
>> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8175120/webrev.01/

This looks good, except the change in KdcPolicy.java. See below:
>> Original review:
>> https://mail.openjdk.java.net/pipermail/security-dev/2017-February/015625.html
>>
>> This is not a clean backport because the tests in 8u differ slightly
>> from those in OpenJDK 10:
>>
>> 1. 8u has "JDK-8190690: Impact on krb5 test cases in the 8u nightly".
>> That same change (adding a property to the @run line) also needs to be
>> applied to the new KdcPolicy.java test for it to succeed.

It looks to me that change to KdcPolicy.java does not relate to 8175120 (this one). It would be
confusing to backport that change under this bug ID? Maybe have a quick and separate 8u-specific fix?

Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/security-dev/attachments/20190313/12c6ae7c/signature-0001.asc>


More information about the security-dev mailing list