RFR[13] JDK-8220410: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed with missing expected output

Weijun Wang weijun.wang at oracle.com
Thu Mar 14 01:52:55 UTC 2019



> On Mar 13, 2019, at 4:58 PM, sha.jiang at oracle.com wrote:
> 
> Hi,
> This fix just makes sure that specified timezone is not null,

Or maybe if it's null then shall we also not pass it to the tools? If I understand correctly, by doing this we also test the default timezone case, which I believe is more common. (At least I don't see it in "java -XshowSettings:properties" on my laptop).

BTW, are you able to reproduce the failure by faking the time? All failures happened from 2019-03-11T07:23:34Z to 2019-03-11T07:32:36Z.

--Max

> and the jar verifying and date formatting use the same different timezone.
> 
> Webrev: http://cr.openjdk.java.net/~jjiang/8220410/webrev.00/
> Issue: https://bugs.openjdk.java.net/browse/JDK-8220410
> 
> Best regards,
> John Jiang
> 




More information about the security-dev mailing list