Code Review Request, JDK-8219991 : New fix of the deadlock in sun.security.ssl.SSLSocketImpl

Alan Bateman Alan.Bateman at oracle.com
Sat May 4 06:27:16 UTC 2019


On 04/05/2019 02:23, Xuelei Fan wrote:
> Hi,
>
> There is a surprise in the regression test.  I made the update, and 
> now the testing passed.  Here is the new webrev:
>     http://cr.openjdk.java.net/~xuelei/8219991/webrev.01/
I assume you can save two volatile writes by not initializing isClosing 
and hasDepleted to false (their initial value).

If readLockedDeplete were to throw an exception (and there several 
opportunities for exceptions in that metho) then read would unwind 
without unlocking. You may need to structure it to reduce that possibility.

-Alan





More information about the security-dev mailing list