RFR(XS): 8223555: Cleanups in cacerts tests
Xuelei Fan
xuelei.fan at oracle.com
Wed May 8 14:06:01 UTC 2019
Thank you! Yes, the change is good to me.
Regards,
Xuelei
On 5/8/2019 7:01 AM, Langer, Christoph wrote:
> Hi Xuelei,
>
> thanks for looking.
>
> The warnings would appear in my Eclipse IDE. During the tests (build) nothing had been observed and this will hopefully still be the same. 😊
>
> So you are good with the changes?
>
> Best regards
> Christoph
>
>> -----Original Message-----
>> From: Xuelei Fan <xuelei.fan at oracle.com>
>> Sent: Mittwoch, 8. Mai 2019 15:58
>> To: Langer, Christoph <christoph.langer at sap.com>; security-dev <security-
>> dev at openjdk.java.net>
>> Subject: Re: RFR(XS): 8223555: Cleanups in cacerts tests
>>
>> Hi Christoph,
>>
>> Did you see compiler warning for the files? I tried with the JDK
>> repository build, no compiler warning message. The update is safe. I
>> may miss something about why we want to make the update.
>>
>> Thanks,
>> Xuelei
>>
>> On 5/8/2019 1:21 AM, Langer, Christoph wrote:
>>> Hi,
>>>
>>> please review this small change which contains a few minor cleanups to
>>> the tests for the CA certificates. I had it in my mercurial queue for
>>> quite some time and always wanted to contribute it 😊
>>>
>>> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8223555.0/
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223555
>>>
>>> Thanks
>>>
>>> Christoph
>>>
More information about the security-dev
mailing list