RFR 8222987: sun/security/tools/keytool/PSS.java times out on Solaris-SPARC

Weijun Wang weijun.wang at oracle.com
Thu May 9 00:51:25 UTC 2019


I've added comments to both and pushed it.

Thanks,
Max

> On May 9, 2019, at 12:24 AM, Sean Mullan <sean.mullan at oracle.com> wrote:
> 
> I think it would be useful to add a comment in the test and/or in the bug report with a brief explanation as to why it is not run on Solaris. Otherwise, fix looks fine.
> 
> --Sean
> 
> On 5/8/19 10:58 AM, Weijun Wang wrote:
>> This test timed out on solaris-sparc multiple times while generating an 8192-bit RSA key pair. Since the test is used to ensure keytool's support for the RSASSA-PSS algorithm (and the default signature algorithm depending on the key size) it's not platform related. Therefore I suggest simply ignoring the test on Solaris.
>> Please take a review on the patch below:
>> diff --git a/test/jdk/sun/security/tools/keytool/PSS.java b/test/jdk/sun/security/tools/keytool/PSS.java
>> --- a/test/jdk/sun/security/tools/keytool/PSS.java
>> +++ b/test/jdk/sun/security/tools/keytool/PSS.java
>> @@ -23,11 +23,12 @@
>> /*
>>  * @test
>> - * @bug 8215694
>> + * @bug 8215694 8222987
>>  * @summary keytool cannot generate RSASSA-PSS certificates
>>  * @library /test/lib
>>  * @modules java.base/sun.security.util
>>  *          java.base/sun.security.x509
>> + * @requires os.family != "solaris"
>>  * @run main PSS
>>  */
>> Thanks,
>> Max




More information about the security-dev mailing list