RFR 8221719: Jarsigner Fails To Verify Signed By Alias If Alias Given In Wrong Case

[Weijun Wang]

Hi Phillip,

I've posted the updated patch to

   https://cr.openjdk.java.net/~weijun/8221719/webrev.01

after making 2 tiny changes. 1) move @test above imports. 2) remove 2 useless imports.

I'm fine with the change. If there's no one else with any extra comment, I'll push it.

Thanks,
Max


> On May 11, 2019, at 4:16 PM, Philipp Kunz <philipp.kunz at paratix.ch> wrote:
> 
> Hi Max,
> 
> You are right. An explicit manifest is not necessary. I don't remember why I added it in the first place. It works also without it.
> 
> Regards,
> Philipp
> 
> 
> On Thu, 2019-05-09 at 16:44 +0800, Weijun Wang wrote:
>> Hi Philipp,
>> 
>> I've posted your patch at
>> 
>>    
>> http://cr.openjdk.java.net/~weijun/8221719/webrev.00/
>> 
>> 
>> Everyone please take a review.
>> 
>> I think it looks fine. Just one question: why do you need to create the Manifest in the test. Can you just create a jar without MANIFEST.MF and let jarsigner add it?
>> 
>> Thanks,
>> Max
>> 
>> 
>>> 
>>> On May 1, 2019, at 10:14 PM, Philipp Kunz <
>>> philipp.kunz at paratix.ch
>>> > wrote:
>>> 
>>> Hi Max and everyone,
>>> 
>>> With respect to the previous patch, parentheses moved from storeHash to printCert, bug number added, and some comments added and clarified.
>>> 
>>> Regards,
>>> Philipp
>>> 
>>> 
>>> 
>> 
>> 
>> 
> <20190511-JavaKeyStoreAliasCaseInsensitive.patch>