JGSS Enhancements (contribution by Two Sigma Open Source)

Michael Osipov 1983-01-06 at gmx.net
Wed May 15 07:56:37 UTC 2019

Am 2019-05-13 um 18:43 schrieb Nico Williams:
> On Sat, May 11, 2019 at 08:02:48AM +0800, Weijun Wang wrote:
>>> On May 10, 2019, at 11:55 PM, Nico Williams <Nico.Williams at twosigma.com> wrote:
>>> Who can review?
>> Anyone who is watching security-dev at . The mail list is quite active.
> OK, thanks.  I'll ask Peter B. to subscribe.
>> We've done this before. Below are the first 3 code review threads of your contributions:
>> 8212165: JGSS: Fix cut/paste error in NativeUtil.c
>> https://mail.openjdk.java.net/pipermail/security-dev/2018-October/018489.html
>> 8212216: JGSS: Fix leak in exception cases in getJavaOID()
>> https://mail.openjdk.java.net/pipermail/security-dev/2018-October/018506.html
>> 8212217: JGSS: Don't dispose() of creds too eagerly
>> https://mail.openjdk.java.net/pipermail/security-dev/2018-October/018507.html
>> You can see Sean and Alan replying, and of course I'll also review all changes.
> I've got new updates coming that respond to the code review comments I
> collated from GitHub and some comments received here.
> I've also added bindings for gss_acquire_cred_from() and
> gss_store_cred_into(), which makes GssLoginModule a drop-in
> replacement for Krb5LoginModule as far as functionality goes.

Terrific! Can you point me to those commits for a review? I am pretty
thrilled to try that out next month when I have some spare cycles on
OpenJDK 11 or 12 on a two-tier platform.


More information about the security-dev mailing list