[ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

Daniel Fuchs daniel.fuchs at oracle.com
Fri May 17 10:00:04 UTC 2019


Hi Arthur,

On 17/05/2019 00:16, Arthur Eubanks wrote:
> bug: https://bugs.openjdk.java.net/browse/JDK-8224081
> webrev: http://cr.openjdk.java.net/~aeubanks/8224081/webrev.00/index.html
> 
> Tests that try to use SOCKS v4 will fail in an IPv6 only environment 
> since SOCKS v4 does not support IPv6. SOCKS v5 does support IPv6.

Your changes to java/net/Socks/SocksProxyVersion.java look good to me.

However I'd like your changes to
test/jdk/sun/security/x509/URICertStore/SocksProxy.java
to be reviewed by the security-dev team which I have added
in cc:, since I believe this falls into their area.

best regards,

-- daniel




More information about the security-dev mailing list