[ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

Arthur Eubanks aeubanks at google.com
Fri May 24 00:14:07 UTC 2019


Ping on a review from security-dev.

On Fri, May 17, 2019 at 9:53 AM Chris Hegarty <chris.hegarty at oracle.com>
wrote:

> Arthur,
>
> On 17 May 2019, at 17:50, Arthur Eubanks <aeubanks at google.com> wrote:
>
> Looks good.
>>
>> Trivially, maybe amend the comment to be more explicit
>>
>>    86       // SOCKS V4 ( requires IPv4 )
>>
>> -Chris.
>>
> Done
> http://cr.openjdk.java.net/~aeubanks/8224081/webrev.02/
>
> I will wait for another review from security-dev.
>
>
> You have my Review ( conditional on a Reviewer for the test in the
> security area ).
>
> -Chris.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/security-dev/attachments/20190523/bf9e74d0/attachment.html>


More information about the security-dev mailing list