[ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

[Arthur Eubanks]

On Fri, May 24, 2019 at 1:56 PM Sean Mullan <sean.mullan at oracle.com> wrote:

> On 5/23/19 8:14 PM, Arthur Eubanks wrote:
> > Ping on a review from security-dev.
> >
> > On Fri, May 17, 2019 at 9:53 AM Chris Hegarty <chris.hegarty at oracle.com
> > <mailto:chris.hegarty at oracle.com>> wrote:
> >
> >     Arthur,
> >
> >>     On 17 May 2019, at 17:50, Arthur Eubanks <aeubanks at google.com
> >>     <mailto:aeubanks at google.com>> wrote:
> >>
> >>         Looks good.
> >>
> >>         Trivially, maybe amend the comment to be more explicit
> >>
> >>            86       // SOCKS V4 ( requires IPv4 )
> >>
> >>         -Chris.
> >>
> >>     Done
> >>     http://cr.openjdk.java.net/~aeubanks/8224081/webrev.02/
> >>
> >>     I will wait for another review from security-dev.
> >
> >     You have my Review ( conditional on a Reviewer for the test in the
> >     security area ).
>
> It seems ok but given that this area is a bit unpredictable I would
> recommend you be available/online to monitor CI results after you push
> the fix in case something breaks.
>
I will submit next week then. Thanks for the review.

>
> --Sean
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20190524/b1b38608/attachment.htm>