RFR(S): Cleanups in sun/security/provider/certpath/ldap/LDAPCertStoreImpl.java
Langer, Christoph
christoph.langer at sap.com
Wed May 29 15:44:42 UTC 2019
Hi Sean,
thanks for the review. I've addressed your points: http://cr.openjdk.java.net/~clanger/webrevs/8224729.2/
Thanks
Christoph
> -----Original Message-----
> From: Sean Mullan <sean.mullan at oracle.com>
> Sent: Dienstag, 28. Mai 2019 15:18
> To: Langer, Christoph <christoph.langer at sap.com>; security-dev <security-
> dev at openjdk.java.net>
> Subject: Re: RFR(S): Cleanups in
> sun/security/provider/certpath/ldap/LDAPCertStoreImpl.java
>
> Hi Christoph,
>
> This is not really a bug, so I would change it to an Enhancement.
>
> 73 // private static final String DELTA_CRL =
> "deltaRevocationList;binary";
>
> I would just remove this line.
>
> Looks good otherwise.
>
> --Sean
>
> On 5/25/19 5:51 AM, Langer, Christoph wrote:
> > Hi,
> >
> > please review this small cleanup which started off under a different
> > subject [0] but turned out to be the wrong thing to do. Still the
> > cleanup parts seem to be valuable, so requesting a review for that here.
> >
> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8224729.1/
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8224729
> >
> > Thanks
> >
> > Christoph
> >
> > [0]
> > https://mail.openjdk.java.net/pipermail/security-dev/2019-
> May/019967.html
> >
More information about the security-dev
mailing list