RFR [14] JDK-8233621 : Mismatch in jsse.enableMFLNExtension property name

Xuelei Fan xuelei.fan at oracle.com
Sat Nov 9 02:35:22 UTC 2019


On 11/8/2019 12:58 PM, Sean Mullan wrote:
> The fix looks good but I noticed that there is an existing test 
> (javax/net/ssl/TLSCommon/MFLNTest.java) that tests this feature using 
> the property name "jsse.enableMFLNExtension". That test should have 
> failed because of the misspelled property. I think you should look into 
> that to see why it didn't work properly - it may need some adjustment.
> 
Good catch!  The system property in the test is not actually used, the 
SSLParameters.setMaximumPacketSize() is used instead. Maybe, the test 
could split into two, one for the system property, and another one for 
the SSLParameters.setMaximumPacketSize() method.

Thanks,
Xuelei

> --Sean
> 
> On 11/8/19 12:22 PM, Xuelei Fan wrote:
>> Hi,
>>
>> May I get the following update reviewed?
>>     http://cr.openjdk.java.net/~xuelei/8233621/webrev.00/
>>
>> Trivial update, no new regression test.
>>
>> The system property, "jsse.enableMFLNExtension", was introduced in JDK 
>> 9 (See JSSE Reference Guides).  However, the implementation code uses 
>> "jsse.enableMFLExtension" (without 'N') instead.
>>
>> With this update, temporarily, if either of the two properties set to 
>> true, the extension is switch on. Note that we may remove the 
>> "jsse.enableMFLExtension" property in the future.  Please don't 
>> continue to use the misspelling property any longer.
>>
>> Thanks,
>> Xuelei



More information about the security-dev mailing list