RFR 8214024: Remove the default keytool -keyalg value

Weijun Wang weijun.wang at oracle.com
Fri Nov 15 12:49:05 UTC 2019



> On Nov 15, 2019, at 8:47 PM, Sean Mullan <sean.mullan at oracle.com> wrote:
> 
> On 11/14/19 7:48 PM, Weijun Wang wrote:
>>> On Nov 15, 2019, at 4:30 AM, Sean Mullan <sean.mullan at oracle.com> wrote:
>>> 
>>> On 11/4/19 8:14 PM, Weijun Wang wrote:
>>>>> Webrev:http://cr.openjdk.java.net/~weijun/8214024/webrev.00/
>>>> Will look at the code changes later.
>>> 
>>> Looks good. Should you add the bugid to one of the tests such as sun/security/tools/keytool/KeyToolTest.java?
>> I think most of them (including KeyToolTest.java) are "adapted" to this change rather than "verifying" it, therefore it seems unnecessary to add the bugid. Only DeprecateKeyalg.java is updated to detect the removal and it's now renamed to RemoveKeyAlgDefault.java.
> 
> Ok, then I think you should add a noreg label to the bug.

No, the bugid appears in RemoveKeyAlgDefault.java.

--Max

> 
> --Sean




More information about the security-dev mailing list