RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma
Ivan Gerasimov
ivan.gerasimov at oracle.com
Wed Oct 2 23:26:05 UTC 2019
Hi Chris!
Thank you very much for review!
I agree that it makes sense to update the javadoc for consistency.
I don't think CSR is required in this case, is it? (IAE is unchecked
anyway, and the fix doesn't really change the behavior.)
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/8230407/01/webrev/
With kind regards,
Ivan
On 10/2/19 6:44 AM, Chris Hegarty wrote:
> Ivan,
>
> On 01/10/2019 21:26, Ivan Gerasimov wrote:
>> Hello!
>>
>> The constructors of SocketPermission and FilePermission expect a
>> String argument with comma-separated list of actions.
>>
>> If the list is malformed, then the constructors throw
>> IllegalArgumentException.
>>
>> It turns out that the current implementation fails to throw IAE if
>> the list starts with a leading comma.
>>
>> Would you please help review a simple fix, which will make the
>> behavior more consistent?
>>
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8230407
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8230407/00/webrev/
>
> The implementation changes look ok.
>
> The SocketPermission constructor should be updated to specify IAE too,
> right?
>
> -Chris.
>
>
--
With kind regards,
Ivan Gerasimov
More information about the security-dev
mailing list