FRF[14] JDK-8228967: Trust/Key store and SSL context utilities for tests

Xuelei Fan xuelei.fan at oracle.com
Thu Sep 5 04:06:16 UTC 2019


Looks good to me.

Xuelei

On 9/4/2019 8:11 PM, sha.jiang at oracle.com wrote:
> Ping...
> 
> In the future, we would use these utilities to refactor some existing 
> tests, which depend on binary trust/key stores.
> 
> I just run all tests in java/security, javax/security, javax/net/ssl and 
> sun/security with this patch.
> The results are fine.
> 
> Best regards,
> John Jiang
> 
> On 2019/8/19 15:17, sha.jiang at oracle.com wrote:
>> Could this patch be reviewed?
>>
>> Best regards,
>> John
>>
>> On 2019/8/4 07:32, sha.jiang at oracle.com wrote:
>>> Hi Sean,
>>> I moved test/jdk/java/security/testlibrary/CertUtils.java  to 
>>> test/lib/jdk/test/lib/security/CertUtils.java, and added the new 
>>> methods to this class.
>>> The affected existing tests are also modified.
>>>
>>> http://cr.openjdk.java.net/~jjiang/8228967/webrev.01/
>>>
>>> Best regards,
>>> John Jiang
>>>
>>> On 2019/8/2 19:26, Sean Mullan wrote:
>>>> Not a full review but there is already a utility class for creating 
>>>> certificates, etc in test/jdk/java/security/testlibrary/CertUtils.java
>>>> Could you combine/merge that with your new CertUtils class?
>>>>
>>>> --Sean
>>>>
>>>> On 8/2/19 4:29 AM, sha.jiang at oracle.com wrote:
>>>>> Hi,
>>>>> This enhancement provides a set of utilities for creating 
>>>>> certificate, trust/key store and SSL context.
>>>>> It provides the default trust and key stores with RSA, ECDSA, 
>>>>> RSASSA-PSS and DSA certificates, and also the default TLS and DTLS 
>>>>> contexts with the default trust and key stores.
>>>>> Three tests are modified for demonstrating the usages.
>>>>>
>>>>> Webrev: http://cr.openjdk.java.net/~jjiang/8228967/webrev.00/
>>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8228967
>>>>>
>>>>> Best regards,
>>>>> John Jiang
>>>>>
>>>>
>>>
>>


More information about the security-dev mailing list