[11u] RFR: 8204203: Many pkcs11 tests failed in Provider initialization, after compiler on Windows changed

Langer, Christoph christoph.langer at sap.com
Fri Sep 6 12:54:28 UTC 2019


Hi,

since there’s apparently no veto on this (nor encouraging statements), I’ll go ahead and push this testfix soon. After all, it’ll just re-enable a few tests where I can’t see problems with. Should somebody run into issues with the tests because of this update, we can always disable them again.

Thanks
Christoph

From: Langer, Christoph
Sent: Mittwoch, 4. September 2019 17:00
To: Baesken, Matthias <matthias.baesken at sap.com>; security-dev at openjdk.java.net; jdk-updates-dev at openjdk.java.net; Aleksey Shipilev <shade at redhat.com>
Subject: RE: [11u] RFR: 8204203: Many pkcs11 tests failed in Provider initialization, after compiler on Windows changed

Hi Matthias,

good point. What do e.g. Redhat folks say about VS2017 requirement? (@Aleksey)

Or will the test also work with these artifacts if using a VS < 2017 to build the JDK? (Maybe somebody on security-dev with some experience with these tests can shed some light on this…)

Thanks
Christoph

From: Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>>
Sent: Mittwoch, 4. September 2019 16:54
To: Langer, Christoph <christoph.langer at sap.com<mailto:christoph.langer at sap.com>>; security-dev at openjdk.java.net<mailto:security-dev at openjdk.java.net>; jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>
Subject: RE: [11u] RFR: 8204203: Many pkcs11 tests failed in Provider initialization, after compiler on Windows changed


Hello Christoph,  the change looks good to me .

However I suggest to wait a day or two  for more feedback ,  because

http://cr.openjdk.java.net/~clanger/webrevs/8204203.11u.0/test/jdk/sun/security/pkcs11/PKCS11Test.java.frames.html


889     @Artifact(
890             organization = "jpg.tests.jdk.nsslib",
891             name = "nsslib-windows_x64",
892             revision = "3.41-VS2017",
893             extension = "zip")
894     private static class WINDOWS_X64 { }
895
 896     @Artifact(
897             organization = "jpg.tests.jdk.nsslib",
898             name = "nsslib-windows_x86",
899             revision = "3.41-VS2017",
900             extension = "zip")


… looks like    everyone executing these tests  on Windows  needs  the VS2017  runtimes , isn’t it ?
Is this really true for  at least the main parties working on   jdk11 ?

In  current  11u-dev  I find :

toolchain_windows.m4:28:VALID_VS_VERSIONS="2017 2013 2015 2012 2010"

Best regards, Matthias



From: Langer, Christoph
Sent: Mittwoch, 4. September 2019 08:24
To: jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>
Cc: security-dev <security-dev at openjdk.java.net<mailto:security-dev at openjdk.java.net>>
Subject: [11u] RFR: 8204203: Many pkcs11 tests failed in Provider initialization, after compiler on Windows changed

Hi,

please review the backport of this testfix to JDK11 updates.

Bug: https://bugs.openjdk.java.net/browse/JDK-8204203
Original Change: http://hg.openjdk.java.net/jdk/jdk/rev/251090f84412
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8204203.11u.0/

The backport differs in that sun/security/tools/keytool/NssTest.java doesn’t exist in 11u and hence the changes for it were omitted.

Jtreg testing over all platforms, especially Windows, shows no regressions.

Thanks
Christoph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20190906/f3ce0b45/attachment.htm>


More information about the security-dev mailing list