RFR: 8231222: fix pkcs11 P11_DEBUG guarded native traces

[Baesken, Matthias]

Hi Christoph, thanks for  the review !
I'll update the Copyright years .

Will push it as XS  tomorrow  in case of no further comments / objections.

Best regards, Matthias


From: Langer, Christoph <christoph.langer at sap.com>
Sent: Montag, 23. September 2019 16:50
To: Baesken, Matthias <matthias.baesken at sap.com>; security-dev at openjdk.java.net
Subject: RE: RFR: 8231222: fix pkcs11 P11_DEBUG guarded native traces

Hi Matthias,

your change looks good to me. Don't forget to update the copyright years before pushing.

Best regards
Christoph

From: security-dev <security-dev-bounces at openjdk.java.net<mailto:security-dev-bounces at openjdk.java.net>> On Behalf Of Baesken, Matthias
Sent: Donnerstag, 19. September 2019 16:28
To: security-dev at openjdk.java.net<mailto:security-dev at openjdk.java.net>
Subject: [CAUTION] RFR: 8231222: fix pkcs11 P11_DEBUG guarded native traces

Hello, please reviews this fix of the  pkcs11  native  tracing    ( P11_DEBUG guarded native traces ).
I had enabled it  to look into   a issue  with pkcs11 not working on  a recently patched Linux system .
But noticed  that the traces did not work any more (probably mostly because  of   changed compilers  and related warning levels ).

With  this change I could  successfully   again  for run on Linux  with traces enabled .

(see pkcs11wrapper.h   P11_DEBUG )


Maybe it would make sense to always  compile  with tracing enabled , and make the trace  depend  on a system property, what do you think ?   (but this would be a separate change) .


Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8231222

http://cr.openjdk.java.net/~mbaesken/webrevs/8231222.0/

Best regards, Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20190923/ce0544ea/attachment.htm>