RFR: 8231351: Add notes for PKCS11 tests in the test doc

Erik Joelsson erik.joelsson at oracle.com
Tue Sep 24 15:19:33 UTC 2019


Sure, will do.

/Erik

On 2019-09-23 20:57, Jia Huang wrote:
> Hi Erik,
>
> Thank you for your review and valuable comments.
>
> Updated: http://cr.openjdk.java.net/~jiefu/8231351-huangjia/webrev.01/
>  - The reference to the pkcs11 README and the reviewers had been added.
>
> Please note the user in the patch.
> Hope you wouldn't mind it. Thanks.
>
> Could you please sponsor it?
>
> Thanks a lot.
> Best regards,
> Jia
>
> 在 2019年09月23日 23:18, Erik Joelsson 写道:
>> I think this type of comment fits well in the top level test doc. It 
>> just provides basic instructions for setting up these tests so that 
>> they pass without going into too much detail. Perhaps a reference to 
>> the pkcs11 README for more details would be a good idea.
>>
>> Looks good to me.
>>
>> /Erik
>>
>> On 2019-09-23 05:54, sha.jiang at oracle.com wrote:
>>> Hi Jia,
>>> I think this isn't a general testing problem.
>>> It may not worthy of highlighting this point in the JDK testing doc.
>>> In fact, PKCS11 tests have their own doc at: 
>>> test/jdk/sun/security/pkcs11/README
>>>
>>> Best regards,
>>> John Jiang
>>>
>>> On 2019/9/23 18:04, Jia Huang wrote:
>>>> Hi all,
>>>>
>>>> JBS:    https://bugs.openjdk.java.net/browse/JDK-8231351
>>>> Webrev: http://cr.openjdk.java.net/~jiefu/8231351-huangjia/webrev.00/
>>>>
>>>> sun/security/pkcs11/Secmod/AddTrustedCert.java failed on Ubuntu 18.04.
>>>> According to the comments in JDK-8231338, it was caused by the 
>>>> improper NSS libs of the system.
>>>>
>>>> These failures are confusing and hard to diagnose.
>>>> It might be better to add some notes for the pkcs11 tests.
>>>>
>>>> Thanks a lot.
>>>>
>>>> Best regards,
>>>> Jia
>>>>
>>>>
>>>>
>
>



More information about the security-dev mailing list