RFR[jdk] 8237474: Default SSLEngine should create in server role

[Xuelei Fan]

Please update copyright year to 2020.

SSLEngine.java
--------------
@@ -1109,10 +1115,14 @@
+     * @implNote
+     * The JDK SunJSSE provider implementation returns false unless 
{@link setUseClientMode}
+     *          is used to change the mode to true.

For the link, I may add parameter, and limit the line under 80 
characters, and don't indent the lines.

+     * @implNote
-     * The JDK SunJSSE provider implementation returns false unless 
{@link setUseClientMode}
-     *          is used to change the mode to true.
+     * The JDK SunJSSE provider implementation returns false unless
+     * {@link setUseClientMode(boolean)} is used to change the mode
+      * to true.

It's fine to leave the CSR  as it is.

Otherwise, looks fine to me.

Xuelei

On 3/30/2020 6:50 AM, Prasadrao Koppula wrote:
> Hi,
> 
> Added @implnote and updated test changes, here is the new webrev, please 
> review it.
> 
> Webrev: http://cr.openjdk.java.net/~pkoppula/8237474/webrev.01/
> 
> issue: https://bugs.openjdk.java.net/browse/JDK-8237474
> 
> CSR: https://bugs.openjdk.java.net/browse/JDK-8238593
> 
> Thanks,
> 
> Prasad.K
> 
> *From:* Prasadrao Koppula
> *Sent:* Friday, February 7, 2020 5:03 PM
> *To:* security-dev at openjdk.java.net
> *Subject:* RFR[jdk] 8237474: Default SSLEngine should create in server role
> 
> Hi,
> 
> Could you please review this patch. Default server role mode was flipped 
> in SSLEngine, to client role mode as part of SSL package code 
> refactoring for TLSv1.3, this patch flips back default client role to 
> server role in SSLEngine.
> 
> webrev: http://cr.openjdk.java.net/~pkoppula/8237474/webrev.00/
> 
> issue: https://bugs.openjdk.java.net/browse/JDK-8237474
> 
> CSR: https://bugs.openjdk.java.net/browse/JDK-8238593
> 
> Thanks,
> 
> Prasad.K
>