RFR JDK-8236464 : SO_LINGER option is ignored by SSLSocket in JDK 11

Xuelei Fan xuelei.fan at oracle.com
Fri Apr 24 18:43:42 UTC 2020


Hi Tony,

Thanks for the review.  I will update the typo before commit.

Xuelei

On 4/24/2020 10:08 AM, Anthony Scarpino wrote:
> On 4/23/20 1:14 PM, Xuelei Fan wrote:
>> Hi,
>>
>> Could I get the following update reviewed?
>>
>> http://cr.openjdk.java.net/~xuelei/8236464/webrev.00/
>>
>> In the current implementation, the sending of close_notify may not 
>> respect the SO_LINGER setting in some circumstances.   With this 
>> update, the delivering of close_notify alert will consider the impact 
>> of the SO_LINGER setting.
>>
>> I can confirm there is an issue per the code, but I cannot reproduce 
>> the issue by myself.  I'm asking for an external help for the testing. 
>> "noreg-hard" and "noreg-external" tags were added to this bug.
>>
>> Thanks,
>>
>> Xuelei
>>
> Looks good..  with one minor typo:
> TransportContext.java
> 259  // Socket transport is a special because of the SO_LINGER impact.
> 
> remove the 'a'
> 
> No need for re-review
> 
> Tony



More information about the security-dev mailing list