Fix for Javadoc errors in java.base

Julia Boes julia.boes at oracle.com
Thu Aug 13 15:05:51 UTC 2020


Hi Vipin,

Thanks for providing this fix, I'm happy to sponsor your change. To 
complete the review, we still need someone to green light the remaining 
changes below. I'm looping in net-dev and security-dev to have a look.

Bug: https://bugs.openjdk.java.net/browse/JDK-8251542

Webrev: http://cr.openjdk.java.net/~jboes/webrevs/8251542/webrev/

Once the review is completed, please provide me with a patch that 
includes a changeset comment as described here: 
https://openjdk.java.net/guide/producingChangeset.html

If you have any questions, let me know.

Cheers,

Julia

> --- old/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java
> 2020-07-25 23:46:21.233726447 +0530
> +++ new/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java
> 2020-07-25 23:46:20.721720857 +0530
> @@ -96,8 +96,6 @@
>        * @param p the prime modulus
>        * @param g the base generator
>        * @param l the private-value length
> -     *
> -     * @exception InvalidKeyException if the key cannot be encoded
>        */
>       DHPrivateKey(BigInteger x, BigInteger p, BigInteger g, int l) {
>           this.x = x;
> --- old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java
> 2020-07-25 23:46:22.241737383 +0530
> +++ new/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java
> 2020-07-25 23:46:21.745732013 +0530
> @@ -1,5 +1,5 @@
>   /*
> - * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2012, 2020, Oracle and/or its affiliates. All rights reserved.
>    * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>    *
>    * This code is free software; you can redistribute it and/or modify it
> @@ -208,7 +208,7 @@
>        *
>        * @return a CallSite, which, when invoked, will return an instance of the
>        * functional interface
> -     * @throws ReflectiveOperationException
> +     * @throws LambdaConversionException
>        */
>       abstract CallSite buildCallSite()
>               throws LambdaConversionException;
> --- old/src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
> 2020-07-25 23:46:23.261748361 +0530
> +++ new/src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
> 2020-07-25 23:46:22.761742991 +0530
> @@ -200,7 +200,6 @@
>        *
>        * @return a CallSite, which, when invoked, will return an instance of the
>        * functional interface
> -     * @throws ReflectiveOperationException
>        * @throws LambdaConversionException If properly formed functional interface
>        * is not found
>        */
> --- old/src/java.base/share/classes/java/net/ServerSocket.java 2020-07-25
> 23:46:26.449782093 +0530
> +++ new/src/java.base/share/classes/java/net/ServerSocket.java 2020-07-25
> 23:46:25.937776742 +0530
> @@ -1,5 +1,5 @@
>   /*
> - * Copyright (c) 1995, 2019, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 1995, 2020, Oracle and/or its affiliates. All rights reserved.
>    * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>    *
>    * This code is free software; you can redistribute it and/or modify it
> @@ -315,7 +315,7 @@
>       /**
>        * Creates the socket implementation.
>        *
> -     * @throws IOException if creation fails
> +     * @throws SocketException if creation fails
>        * @since 1.4
>        */
>       void createImpl() throws SocketException {
> --- old/src/java.base/share/classes/java/net/Socket.java 2020-07-25
> 23:46:27.485792869 +0530
> +++ new/src/java.base/share/classes/java/net/Socket.java 2020-07-25
> 23:46:26.973787565 +0530
> @@ -533,7 +533,7 @@
>        *
>        * @param stream a {@code boolean} value : {@code true} for a TCP socket,
>        *               {@code false} for UDP.
> -     * @throws IOException if creation fails
> +     * @throws SocketException if creation fails
>        * @since 1.4
>        */
>        void createImpl(boolean stream) throws SocketException {


More information about the security-dev mailing list