RFR: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files [v4]
Valerie Peng
valeriep at openjdk.java.net
Tue Dec 1 00:49:13 UTC 2020
> Could someone please help review this PKCS#11 v3.0 header files update?
>
> Changes are straight-forward as below:
> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0
> 2) Updated java side w/ the new constants definitions and name/error code mappings.
>
> For the native headers, it's a direct copy of the official v3.0 headers except that I have to remove the tab space, and trailing white spaces due to JDK code requirement. I verified the result using 'diff -w'. As for the java side, the edit is based on the diff of native headers. I also commented out some of the unused native identifiers at java side.
>
> I am adding the SHA-3 digests, signatures, and macs in a separate RFE and would need this one to be reviewed/integrated first.
>
> Thanks,
> Valerie
Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
Update the license file
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/917/files
- new: https://git.openjdk.java.net/jdk/pull/917/files/03f1b67a..74bdf869
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=917&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=917&range=02-03
Stats: 69 lines in 1 file changed: 40 ins; 0 del; 29 mod
Patch: https://git.openjdk.java.net/jdk/pull/917.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/917/head:pull/917
PR: https://git.openjdk.java.net/jdk/pull/917
More information about the security-dev
mailing list