RFR: 8253821: Improve ByteBuffer performance with GCM [v5]

Anthony Scarpino ascarpino at openjdk.java.net
Wed Dec 2 03:05:09 UTC 2020


On Tue, 1 Dec 2020 22:44:44 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - test updates
>>  - test check mixup
>>  - Overlap protection
>>  - Updated code comments, all tests pass
>>  - Updated code comments, all tests pass
>
> src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 554:
> 
>> 552:                 ibuffer.reset();
>> 553:                 // Code below will write the remainder from 'in' to ibuffer
>> 554:             } else if (blen > 0) {
> 
> Instead of blen >0, maybe you meant remainder > 0?

Yes, you're right, it should be remainder.

-------------

PR: https://git.openjdk.java.net/jdk/pull/411



More information about the security-dev mailing list