RFR: JDK-8257401: Use switch expressions in jdk.internal.net.http and java.net.http [v4]
Daniel Fuchs
dfuchs at openjdk.java.net
Wed Dec 2 16:25:59 UTC 2020
On Wed, 2 Dec 2020 09:42:09 GMT, Kartik Ohri <github.com+27751938+amCap1712 at openjdk.org> wrote:
>> Hi!
>> Kindly review this patch to replace switch statements with switch expressions (where it makes sense) in the http client modules. The rationale is to improve readability of the code.
>> Regards,
>> Kartik
>
> Kartik Ohri has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
src/java.net.http/share/classes/jdk/internal/net/http/frame/SettingsFrame.java line 82:
> 80: case MAX_HEADER_LIST_SIZE -> "MAX_HEADER_LIST_SIZE";
> 81:
> 82: default -> "unknown parameter";
> Check failure on line 81 in src/java.net.http/share/classes/jdk/internal/net/http/frame/SettingsFrame.java
> openjdk / jcheck
>
> Whitespace error
>
> Column 0: trailing whitespace
> ...
WRT to whitespace errors detected by `jcheck`, note that you can fix them by running the script:
make/scripts/normalizer.pl
on this file.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1364
More information about the security-dev
mailing list