RFR: 8026976: ECParameters, Point does not match field size [v2]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Thu Dec 3 16:43:56 UTC 2020


On Wed, 2 Dec 2020 23:32:27 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Save a operation could get a little bit performance.  Comparing to "if (!a)", "if (a)" is easier to read to me, and save me a cycle to compute the "!".  Anyway, not a big concern of mine, you can leave it as is if you prefer the "if (!a)" style.
>
> Just to finish up the thought.  The assembly instructions are the same using if(!a) or if(a).  The difference would be how the code is setup during compile time and I believe that would be the same speed as well..

Thank you for the check.  It looks good to me and I have no more comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1568



More information about the security-dev mailing list