RFR: 8257725: No throws of SSLHandshakeException [v2]

Xue-Lei Andrew Fan xuelei at openjdk.java.net
Fri Dec 4 18:33:26 UTC 2020


> In the StatusResponseManager.get() method spec, the SSLHandshakeException is declared as throws exception. However, no such checked-exception would be thrown in the method implementation. 
> 
> /** 
> ... 
>  * @throws SSLHandshakeException if an unsupported 
>  * {@code CertStatusRequest} is provided. 
>  */ 
> Map<X509Certificate, byte[]> get(CertStatusRequestType type, 
>             CertStatusRequest request, X509Certificate[] chain, long delay, 
>             TimeUnit unit) {
> 
> As the exception is a checked-exception, and is not declared in the method, it is safe to remove the throws spec.
> 
> Cleanup only, no new regression test.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8257725

Xue-Lei Andrew Fan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge
 - 8257725: No throws of SSLHandshakeException
 - 8257724: Incorrect package of the linked class in BaseSSLSocketImpl

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1607/files
  - new: https://git.openjdk.java.net/jdk/pull/1607/files/13d84784..b5fc532f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1607&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1607&range=00-01

  Stats: 2303 lines in 75 files changed: 1713 ins; 207 del; 383 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1607.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1607/head:pull/1607

PR: https://git.openjdk.java.net/jdk/pull/1607



More information about the security-dev mailing list