RFR: 8242332: Add SHA3 support to SunPKCS11 provider [v2]
Valerie Peng
valeriep at openjdk.java.net
Sat Dec 5 00:47:34 UTC 2020
> Could someone please help review this RFE? SunPKCS11 provider is updated with SHA-3 support, including MessageDigest, Hmac Mac, DSA/RSA/RSASSA-PSS/ECDSA Signature, and Hmac KeyGenerator.
>
> As SHA-3 can be used as drop-in replacement for SHA-2 which are already supported by SunPKCS11 provider, the changes for MessageDigest, Mac, and Signature are straightforward. P11KeyGenerator class is updated to support general Hmac key generation including SHA-3 and more.
>
> While testing against NSS 3.57, there are some unexpected NSS errors with CKM_ECDSA_SHA[224/256/384/512/3_224/3_256/3_384/3_512] and CKM_DSA_SHA[224/256/384/512/3_224/3_256/3_384/3_512], so I disabled those mechanisms in the NSS config file for regression tests. For ECDSA signatures, SunPKCS11 provider will fallback to CKM_ECDSA and do the digesting ourselves.
>
> Thanks,
> Valerie
Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
Removed commented out code and minor cleanups on 2 RSASSA-PSS-related tests
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1546/files
- new: https://git.openjdk.java.net/jdk/pull/1546/files/7b0d7882..4f7488b6
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1546&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1546&range=00-01
Stats: 5 lines in 2 files changed: 0 ins; 2 del; 3 mod
Patch: https://git.openjdk.java.net/jdk/pull/1546.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1546/head:pull/1546
PR: https://git.openjdk.java.net/jdk/pull/1546
More information about the security-dev
mailing list