RFR: 8257769: Cipher.getParameters() throws NPE for ChaCha20-Poly1305 [v2]

Jamil Nimeh jnimeh at openjdk.java.net
Mon Dec 7 20:02:15 UTC 2020


On Mon, 7 Dec 2020 19:35:27 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Jamil Nimeh has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   pre-init getParameters nonce data is now a local variable
>
> src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java line 232:
> 
>> 230:             // this call should cause a random nonce to be generated, but
>> 231:             // not attached to the object.
>> 232:             byte[] nonceData = initialized ? nonce : createRandomNonce(null);
> 
> A minor unrelated comment is that createRandomNonce() could be made static.

Easy enough to do.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1644



More information about the security-dev mailing list