RFR: 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo [v8]

Mon Dec 21 09:47:59 UTC 2020

On Mon, 21 Dec 2020 09:16:11 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

>> 8080272  Refactor I/O stream copying to use java.io.InputStream.transferTo
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
>   revert changes in Apache Santuario

I'm not a reviewer, but still think we could simplify `sun.security.tools.keytool.Main`

src/java.base/share/classes/sun/security/tools/keytool/Main.java line 2459:

> 2457:                 byte[] bytes = in.readAllBytes();
> 2458:                 return CertificateFactory.getInstance("X509").generateCRLs(
> 2459:                         new ByteArrayInputStream(bytes));

Let's just pass `in` into `generateCRLs` instead of reading all bytes and rewrapping them into `InputStream` again?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1853