RFR: 8258736: No break in the loop

Bradford Wetmore wetmore at openjdk.java.net
Mon Dec 21 18:40:54 UTC 2020


On Sat, 19 Dec 2020 05:48:53 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

> It looks like the break is missed in the loop of the SSLCipher.createReadCipher() and createWriteCipher() methods.  See the change set.
> 
> Code cleanup, no new regression test.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8258736

Approved with the condition of updating the copyright year.  

There was also a failure in the Linux Presubmit tests which is probably bogus.

Looks good otherwise.

-------------

Marked as reviewed by wetmore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1848



More information about the security-dev mailing list