[15] RFR 8236512: PKCS11 Connection closed after Cipher.doFinal and NoPadding

Xuelei Fan xuelei.fan at oracle.com
Fri Feb 7 06:55:29 UTC 2020


Hi Valerie,

The overall update looks straightforward to me.  But I'm not sure the 
update that why you want to ignore cancel operation exception for 
verification/decryption?

Thanks,
Xuelei

On 2/6/2020 3:13 PM, Valerie Peng wrote:
> Ping~
> 
> Submitter confirmed that the current webrev addresses the issue.
> 
> Thanks,
> 
> Valerie
> 
> On 1/24/2020 2:01 PM, Valerie Peng wrote:
>> Hi,
>>
>> Can someone help reviewing this? This can only be reproduced with 3rd 
>> party HSM vendor, so there is no new regression test. To address this, 
>> I removed the killSession() calls from PKCS11 Cipher, Mac, Signature 
>> services and reverted to old behavior of finishing off the current 
>> operation as a way of resetting the current object. Also fixed one 
>> place missing the reset() call and another one with redundant reset() 
>> call so the key id counting matches up.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8236512
>>
>> Webrev: http://cr.openjdk.java.net/~valeriep/8236512/webrev.00/
>>
>> Mach5 run is clean.
>>
>> Thanks,
>> Valerie


More information about the security-dev mailing list