RFR 8245306 : Update sun.security.ssl.SSLLogger to use Immutable DateTimeFormatter
Alan Bateman
Alan.Bateman at oracle.com
Wed Jul 22 12:39:28 UTC 2020
On 20/07/2020 17:36, Rahul Yadav wrote:
> Hello,
>
> Request to have my fix reviewed for issue:
>
> JDK-8245306 : Update sun.security.ssl.SSLLogger to use Immutable
> DateTimeFormatter
>
> This fix updates sun.security.ssl.SSLLogger to use immutable
> DateTimeFormatter in place of ThreadLocal,
> this is an effort as part of Project Loom, to replace usages of
> ThreadLocal wherever feasible, to
> improve virtual thread memory efficiency.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8245306
> webrev: http://cr.openjdk.java.net/~ryadav/webrev_8245306/index.html
The replacing of the TL looks good to me.
Style-wise then I would probably declare pattern as a static final so
that it is compiled in the initializer but it's not important. If you do
change anything then the pattern strings can be final.
-Alan
More information about the security-dev
mailing list