RFR 8246397: Use KnownOIDs for known OIDs

Xuelei Fan xuelei.fan at oracle.com
Wed Jun 3 14:10:41 UTC 2020


It looks good to me.

BTW, I may declare KnownOIDs.oid as final and use it directly, rather 
than use the value() method.

Xuelei

On 6/2/2020 11:27 PM, Weijun Wang wrote:
> Please review the code change at
> 
>     http://cr.openjdk.java.net/~weijun/8246397/webrev.00/
> 
> The following KnownOIDs lines are related, in case you want to compare the values.
> 
> 59:    SubjectKeyID("2.5.29.14"),
> 60:    KeyUsage("2.5.29.15"),
> 61:    PrivateKeyUsage("2.5.29.16"),
> 62:    SubjectAlternativeName("2.5.29.17"),
> 65:    CRLNumber("2.5.29.20"),
> 68:    InvalidityDate("2.5.29.24"),
> 72:    NameConstraints("2.5.29.30"),
> 74:    CertificatePolicies("2.5.29.32"),
> 75:    CE_CERT_POLICIES_ANY("2.5.29.32.0"),
> 77:    AuthorityKeyID("2.5.29.35"),
> 79:    extendedKeyUsage("2.5.29.37"),
> 372:    X25519("1.3.101.110"),
> 373:    X448("1.3.101.111"),
> 
> Noreg-cleanup.
> 
> Thanks,
> Max
> 



More information about the security-dev mailing list