RFR[15] JDK-8244683: A TSA server used by tests

[Weijun Wang]

Looks fine to me.

Thanks,
Max


> On Jun 5, 2020, at 8:53 AM, sha.jiang at oracle.com wrote:
> 
> Hi Max
> Please review this webrev:
> http://cr.openjdk.java.net/~jjiang/8244683/webrev.05/
> 
> - TimestampCheck.java
> The codes in those private methods in Interceptor are merged into
> getRespParam().
> 
> - TsaParam.java
> Group the fields as signing internals and TSA fields.
> 
> - TsaSigner.java
> parseRequestParam() and createResponse() are private now.
> 
> Best regards,
> John Jiang
> 
> On 2020/6/4 22:18, Weijun Wang wrote:
>> OK. Please go on. No other comment.
>> 
>>> On Jun 4, 2020, at 12:02 AM, sha.jiang at oracle.com wrote:
>>> 
>>>> Can we make them internal at the moment until someone really need to extend it?
>>> Yes, we can.
>>> But as a test lib, is it bad to think about a bit further?
>> But think about it carefully when there are new requirements. It's probably not a good idea to make every method overridable at the beginning and say do whatever you want.
>> 
>> Thanks,
>> Max
>>