[15] RFR JDK-8246031: Hang observed with coherence SSLNIOServer test

Prasadrao Koppula prasadarao.koppula at oracle.com
Thu Jun 11 08:50:48 UTC 2020


Thanks for review Xuelei,

Removed handleException changes. Please review the change from latest webrev[1]

>+                } else {
>+                    handleException(iioe);

handleException throws exception for InterruptedIOException without closing the connection. A direct conContext.fatal call helps to close the connection. Updated the code accordingly.
  
>+                }

Thanks,
Prasad.K

[1] http://cr.openjdk.java.net/~pkoppula/8246031/webrev.01/   

>-----Original Message-----
>From: Xuelei Fan
>Sent: Wednesday, June 10, 2020 10:13 PM
>To: security-dev at openjdk.java.net
>Subject: Re: [15] RFR JDK-8246031: Hang observed with coherence
>SSLNIOServer test
>
>It may be not needed to update the handleException() method.
>
>- 440            handleException(iioe);
>+ 440            if (resumable) {
>+                    throw iioe;
>+                } else {
>+                    handleException(iioe);

handleException throws exception for InterruptedIOException without closing the connection. A direct conContext.fatal call helps to close the connection. Update the code accordingly.
  

>+                }
>
>Otherwise, looks good to me.
>
>Xuelei
>
>On 6/4/2020 8:13 AM, Prasadrao Koppula wrote:
>> Hi,
>>
>> Could you please review this patch. For timeout/interrupts, JDK11u+
>> releases, SSLSocket:getSession behavior is different, compare to JDK8u.
>> i.e, connection is in open state for timeout/interrupts exception. For
>> comparability reasons, this fix will close connection for getSession
>> timeout/ interrupts.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8246031
>>
>> Webrev: http://cr.openjdk.java.net/~pkoppula/8246031/webrev.00/
>>
>> Thanks,
>>
>> Prasad.K
>>



More information about the security-dev mailing list