RFR 8247907: XMLDsig logging does not work

Sean Mullan sean.mullan at oracle.com
Fri Jun 19 18:12:12 UTC 2020


Looks good. Interesting use of StackWalker. I would recommend adding 
some comments about that, and that the use of "2" is extremely important 
if any of this code is moved around such that the stack frames are 
different.

--Sean

On 6/19/20 10:32 AM, Weijun Wang wrote:
> Please take a review at
> 
>     http://cr.openjdk.java.net/~weijun/8247907/webrev.00/
> 
> I also take this chance to get the class and method names correct in the log.
> 
> Thanks,
> Max
> 



More information about the security-dev mailing list