[RFR] 8166597: Crypto support for the EdDSA Signature Algorithm (JEP 339)
Sean Mullan
sean.mullan at oracle.com
Fri Mar 6 18:22:54 UTC 2020
It will take me a few iterations to review all of this, but here are
some comments so far, mostly minor things:
- src/java.base/share/classes/java/security/spec/NamedParameterSpec.java
Need "@since 15" on the two new constants. (Assuming this goes in 15).
- src/java.base/share/classes/sun/security/util/ArrayUtil.java
35 * This class holds various utility methods for arrays.
The previous comment sounded more specific, why did you change it?
- src/java.base/share/classes/sun/security/x509/AlgorithmId.java
906 public static ObjectIdentifier ed25519_oid =
907 ObjectIdentifier.of("1.3.101.112");
908 public static ObjectIdentifier ed448_oid =
909 ObjectIdentifier.of("1.3.101.113");
Make them final.
--Sean
On 2/25/20 3:49 PM, Anthony Scarpino wrote:
> Hi
>
> I need a code review for the EdDSA support in JEP 339. The code builds
> on the existing java implemented constant time classes used for XDH and
> the NIST curves. The change also adds classes to the public API to
> support EdDSA operations.
>
> All information about the JEP is located at:
> JEP 339: https://bugs.openjdk.java.net/browse/JDK-8199231
> CSR: https://bugs.openjdk.java.net/browse/JDK-8190219
>
> webrev: https://cr.openjdk.java.net/~ascarpino/8166597/webrev/
>
> thanks
>
> Tony
More information about the security-dev
mailing list