[15] RFR 8172680: Support SHA-3 based Hmac algorithms

[Bernd Eckenfels]

Hello Valerie.

In MacKAT 121 you would get a NPE if the catch prints the skip message, probably needs an additional return; guard?

The BAOS default length change in parse() was not immediately clear to me? (Maybe next s. Base64?)

BTW It is good to see that you also add truncated SHA512 variants. It's not mentioned in commit message or RFE.

hTH
Bernd



--
http://bernd.eckenfels.net
________________________________
Von: security-dev <security-dev-bounces at openjdk.java.net> im Auftrag von Valerie Peng <valerie.peng at oracle.com>
Gesendet: Wednesday, March 18, 2020 11:57:37 PM
An: OpenJDK Dev list <security-dev at openjdk.java.net>
Betreff: [15] RFR 8172680: Support SHA-3 based Hmac algorithms


Anyone has time to help review this straight forward RFE? It's to add
SHA-3 support to Hmac.

RFE: https://bugs.openjdk.java.net/browse/JDK-8172680

Webrev: http://cr.openjdk.java.net/~valeriep/8172680/webrev.00/

Mach5 run is clean.

Thanks,
Valerie
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20200318/ac094fa9/attachment.htm>