[15] RFR: 8209632: Develop new tests for EdDSA API
sibabrata.sahoo at oracle.com
sibabrata.sahoo at oracle.com
Thu May 14 04:50:55 UTC 2020
It’s a typo issue. I can add missing character “d” before pushing the change.
Thanks,
Siba
> On 14-May-2020, at 9:00 AM, Anthony Scarpino <anthony.scarpino at oracle.com> wrote:
>
> On 5/13/20 2:55 AM, sibabrata.sahoo at oracle.com wrote:
>> Hi Tony,
>> Please review the patch of new Tests developed for EdDSA,
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8209632
>> Webrev: http://cr.openjdk.java.net/~ssahoo/8209632/webrev.00/
>> Thanks,
>> Siba
>
> Looking through the tests, I didn't see any problems. They looked good to me. Just one thing caught my eye.
>
> EdDSANegativeTest.java:
>
> I noticed you have InvaliPrivateKey and InvaliPublicKey. I assume that was not intentional to leave the 'd' out. I don't mind it being left out if that was your choice.
>
> thanks
>
> Tony
More information about the security-dev
mailing list