RFR: 8253821: Improve ByteBuffer performance with GCM [v3]

[Anthony Scarpino]

On Mon, 2 Nov 2020 17:51:03 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - style
>>  - style & comments
>>  - full update
>>  - remove old
>>  - update
>>  - outputsize
>
> src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 726:
> 
>> 724: 
>> 725:         // check output buffer capacity
>> 726:         if (getMode() != GCM_MODE && (output == null ||
> 
> Is the buffer size for GCM checked somewhere else? For decryption, it's probably ok to skip the check as no output is returned until doFinal(...). For encryption, there is still a chance for ShortBufferException? Javadoc states that for ShortBufferException, the call can be re-tried with a larger buffer.

I know the short buffers were being checked, but I removed the mode check, the tests still pass fine, so I figured this must be a unnecessary change.

-------------

PR: https://git.openjdk.java.net/jdk/pull/411