RFR: 8253821: Improve ByteBuffer performance with GCM [v3]

Valerie Peng valeriep at openjdk.java.net
Tue Nov 3 01:34:02 UTC 2020


On Fri, 23 Oct 2020 16:38:01 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> 8253821: Improve ByteBuffer performance with GCM
>
> Anthony Scarpino has updated the pull request incrementally with six additional commits since the last revision:
> 
>  - style
>  - style & comments
>  - full update
>  - remove old
>  - update
>  - outputsize

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 514:

> 512:             }
> 513:             len -= remainder;
> 514:             ibuffer.write(in, len, remainder);

Any chance that 'ibuffer' already contains earlier buffered bytes? If 'ibuffer' contains bytes. then these need to be processed before processing 'in' and you can't write the to-be-processed bytes into 'ibuffer' here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/411



More information about the security-dev mailing list