RFR: 8253821: Improve ByteBuffer performance with GCM [v3]

Valerie Peng valeriep at openjdk.java.net
Tue Nov 3 21:07:59 UTC 2020


On Fri, 23 Oct 2020 16:38:01 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> 8253821: Improve ByteBuffer performance with GCM
>
> Anthony Scarpino has updated the pull request incrementally with six additional commits since the last revision:
> 
>  - style
>  - style & comments
>  - full update
>  - remove old
>  - update
>  - outputsize

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 541:

> 539:         throws IllegalBlockSizeException, ShortBufferException {
> 540:         checkDataLength(processed, Math.addExact(len, tagLenBytes));
> 541: 

Now that encrypt(byte[], int, int, byte[], int) may also store data into 'ibuffer', shouldn't this encryptFinal() method processes bytes in 'ibuffer' before processing 'in'? The check here would also needs to be updated with ibuffer.size()? If this is true, can this be covered in the added regression tests?

-------------

PR: https://git.openjdk.java.net/jdk/pull/411


More information about the security-dev mailing list